fix(desktop): preserve main window geometry across toolbar mode - #1789
Merged
Conversation
Keep transient floating-window bounds out of the persisted main-window state, repair legacy undersized startup geometry, and restore the standard client minimum after leaving toolbar mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Toolbar mode morphs the existing main window into a compact floating surface. The window-state plugin cached those resize and move events, then wrote the floating bounds during shutdown. The next launch restored that transient geometry as if it were the normal client window.
Verification
pnpm run type-check:webcargo check -p bitfun-desktopcargo test -p bitfun-desktop main_window_geometry_tests --libcargo test -p bitfun-desktop every_registered_command_declares_a_remote_workspace_policy --libcargo test -p bitfun-cli peer_host::dispatch::tests::local_only_commands_are_deniedcargo build -p bitfun-desktopgit diff --checkVisuals
Not applicable: this corrects native startup/restoration geometry without changing the rendered UI.
AI-assisted. Testing level: fully tested for the touched paths.